-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add an "Edit Versions" listing to the Admin menu #6110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This will let users easily find the current version editing UI, and be the place we'll eventually move it after a refactor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually don't like to have two ways of doing the same thing. I think this was the one of reasons why we deleted the Edit Version form from here. Although, it seems that removing this has been confusing users (I didn't hear anything about, but I suppose you did and that's why you are considering this changeset) and considering that we are adding just a link to the Version listing page and not a new one, I'm fine with this change for now.
To clarify, we had some conversations around this: we removed the wrong UI. Or rather, we should have moved the dashboard version list page into the admin dashboard, replacing that mess of a UI. I might have originally brought up the idea to remove the dashboard version page, but I might not have been clear that the project dashboard version list page is the one that is unnecessary. We already have a version list on the project dashboard page, the version listing page therefore is redundant for reader users, and the admin interactions that a maintainer takes shouldn't be on the project dashboard, but should be on the admin dashboard instead. So the ultimate plan is to backtrack a little on this change, move the existing UI into the admin dashboard, and remove the dashboard version listing page. We'll likely have to do the reverse linking then and temporarily link the project dashboard version button to the admin dashboard version listing view. |
Removing the dashboard listing page, will remove this page https://readthedocs.org/projects/sphinx-hoverxref/versions/ that is accessible for anonymous users. In that page, you can see all the active versions and their docs. Although, the same behavior is at the project home page as well: https://readthedocs.org/projects/sphinx-hoverxref/ |
Yup, that's my point above. The project dashboard version list view is not a helpful view for reader users and can be removed entirely. Leo was already instructed to make this change in the project spec, but we removed the wrong UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raised on a previous conversation, I think the version link should be bumped up in the list to where it was originally. Change looks good otherwise 👍
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This will let users easily find the current version editing UI,
and be the place we'll eventually move it after a refactor.