Skip to content

📖 Docs general improvements 📖 #6099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

📖 Docs general improvements 📖 #6099

wants to merge 9 commits into from

Conversation

tapaswenipathak
Copy link
Contributor

@tapaswenipathak tapaswenipathak commented Aug 24, 2019 •
edited
Loading

☀️ Fix #5771. ☀️

  • Improvement in titles
  • Remove/add any extra docs
  • Docs splitting and adding index files

@tapaswenipathak tapaswenipathak changed the title Docs general improvements 📖 Docs general improvements 📖 Aug 24, 2019
stsewd
stsewd reviewed Aug 26, 2019
View reviewed changes
stsewd
stsewd reviewed Aug 26, 2019
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changes in titles look good.

Note for ourselves: add redirects for the pages that were moved

@tapaswenipathak
Copy link
Contributor Author

@stsewd: done.

@stsewd
Copy link
Member

stsewd commented Sep 5, 2019

@tapaswenipathak there is an error on the CI server, make sure your branch is up to date with master.

@tapaswenipathak
Copy link
Contributor Author

@stsewd: Inline commit removes that.

@stsewd
Copy link
Member

stsewd commented Sep 6, 2019

@tapaswenipathak CI is still failing, you can check how to run tests locally here https://docs.readthedocs.io/en/stable/development/tests.html and fix them.

@tapaswenipathak tapaswenipathak force-pushed the general-improvements branch 4 times, most recently from 544afc8 to c5e962e Compare October 16, 2019 06:29
@tapaswenipathak
Copy link
Contributor Author

tapaswenipathak commented Oct 16, 2019 •
edited
Loading

Just a note: weirdly, the paths are erroring. I don't get them when I run the tests, fixing.

@tapaswenipathak tapaswenipathak force-pushed the general-improvements branch 5 times, most recently from 3e2ef61 to 5c385f0 Compare October 16, 2019 12:57
@tapaswenipathak
Copy link
Contributor Author

@stsewd: fixed Travis, review ping.

@stale
Copy link

stale bot commented Nov 30, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Nov 30, 2019
@stale stale bot closed this Dec 7, 2019
@stsewd stsewd removed the Status: stale Issue will be considered inactive soon label Dec 9, 2019
@stsewd
Copy link
Member

stsewd commented Dec 9, 2019 •
edited
Loading

Sorry, haven't time to re-review this. Still valid.

Also, there are merge conflict to solve. And btw, we don't update the po files, we have a script which makes that change for us, so it's easy to review only the files related to the docs.

@stsewd stsewd reopened this Dec 9, 2019
@stale
Copy link

stale bot commented Jan 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jan 24, 2020
@stale stale bot closed this Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd left review comments

Assignees
No one assigned
Labels
Status: stale Issue will be considered inactive soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

General improvements to our docs
2 participants
@tapaswenipathak @stsewd