GitLab Build Status Reporting for PR Builder #6076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saadmk11
added
PR: work in progress
|
Was hoping that would rebase the commits, but we need to update this now that #6066 is merged. |
saadmk11
force-pushed
the
gitlab-build-status
branch
from
cda0762 to
b4e7834
Compare
|
@ericholscher Updated the PR |
3 tasks
ericholscher
approved these changes
Aug 20, 2019
| @@ -356,8 +356,8 @@ def test_send_build_status_task_with_remote_repo(self, send_build_status): | |||
| ) | |||
| self.assertEqual(Message.objects.filter(user=self.eric).count(), 0) | |||
|
|
|||
| @patch('readthedocs.projects.tasks.GitHubService.send_build_status') | |||
| def test_send_build_status_task_with_social_account(self, send_build_status): | |||
| @patch('readthedocs.oauth.services.github.GitHubService.send_build_status') | |||
There was a problem hiding this comment.
Why did this change? It seems like it was wrong before?
There was a problem hiding this comment.
Because we are not directly importing GitHubService to the tasks we are using project.git_service_class()
There was a problem hiding this comment.
It was working before because I forgot to remove an unused import of GitHubService
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created on top of #6066. PR: #6066 should be merged first.
ref: #6052