Auto Sync and Re-Sync for Manually Created Integrations #6071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saadmk11
added
the
PR: work in progress
saadmk11
changed the title
| integration is not functioning correctly, try resyncing the webhook: | ||
| This webhook was configured when this project was imported | ||
| or it was manually created with correct configuration. If this | ||
| integration is not functioning correctly, try re-syncing the webhook: |
There was a problem hiding this comment.
This looks good, but I'd like to see us always displaying the webhook URL information, so that users can confirm that the automated webhook is the one they see in their GitHub admin. We should always show this data.
|
BTW, this is so much better than making users login to GitHub and create the webhook manually. This is a huge win! |
saadmk11
removed
the
PR: work in progress
|
@ericholscher ready for a full review :) |
ericholscher
approved these changes
Aug 20, 2019
| user_pk=self.request.user.pk, | ||
| integration=self.object | ||
| ) | ||
| if self.object.integration_type != Integration.API_WEBHOOK: |
There was a problem hiding this comment.
Do we not have some kind of has_sync check here? I feel like this might break in the future as we add new types of Integration.
There was a problem hiding this comment.
Thanks. I think what you said would be better. :)
There was a problem hiding this comment.
@ericholscher Updated the PR!
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of work needs to be done and a lot of cases needs to be handled before its ready for review. :)
closes #3932
related to the first step of #6052