Skip to content

Moving READTHEDOCS application settings to RTD prefix for docker only #6032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

Iamshankhadeep
Copy link
Contributor

fixes #5586

@dojutsu-user
Copy link
Member

Hi @Iamshankhadeep
I noticed that you close the previous PR and make another PR if any changes are required.
This is generally not how it's done.
I would recommend you to read this article -- https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github -- to make yourself familiar with the correct workflow.

Also, Pull request from master branch are generally discouraged.

@Iamshankhadeep
Copy link
Contributor Author

@dojutsu-user thanks I will be sure to update the required things.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Iamshankhadeep! Thanks for your contribution.

Please do not open a new PR after someone has done a review, but keep making the changes in the same branch and pushing those commits. This will help us to keep reviewing.

That said, please consider taking a look at other places where these settings appear, like https://docs.readthedocs.io/en/latest/development/buildenvironments.html#configuration

Thanks,

@Iamshankhadeep
Copy link
Contributor Author

@humitos I think I made a mistake by deleting the forked repo of readthedocs from where this PR was opened. I followed @dojutsu-user's instruction and deleted the previous repo and froked again and also added a new branch specific for this work. I think I need to close this PR and open new PR and from there If needed I can rebase it.Sorry, a beginner in this open source contribution. If you say to close this PR and open a new one I will be more than happy to do so.

@dojutsu-user
Copy link
Member

@Iamshankhadeep
I am closing this PR since the forked repo is deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move our application settings to a READTHEDOCS prefix on our settings
3 participants