Skip to content

Fix missing arg in tests #6022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Fix missing arg in tests #6022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion readthedocs/projects/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1917,7 +1917,7 @@ def send_build_status(build_pk, commit, status):
for account in user_accounts:
# Currently we only support GitHub Status API
if account.provider_name == 'GitHub':
success = account.send_build_status(build, status)
success = account.send_build_status(build, commit, status)
if success:
return True

Expand Down
8 changes: 6 additions & 2 deletions readthedocs/rtd_tests/tests/test_celery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,9 +362,13 @@ def test_send_build_status_task_with_social_account(self, send_build_status):
external_build = get(
Build, project=self.project, version=external_version
)
tasks.send_build_status(external_build.id, BUILD_STATUS_SUCCESS)
tasks.send_build_status(
external_build.id, external_build.commit, BUILD_STATUS_SUCCESS
)

send_build_status.assert_called_once_with(external_build, BUILD_STATUS_SUCCESS)
send_build_status.assert_called_once_with(
external_build, external_build.commit, BUILD_STATUS_SUCCESS
)

@patch('readthedocs.projects.tasks.GitHubService.send_build_status')
def test_send_build_status_task_without_remote_repo_or_social_account(self, send_build_status):
Expand Down