Skip to content

Fix issues around remote repository for sending Build status reports #6017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2019
Merged

Fix issues around remote repository for sending Build status reports #6017

merged 2 commits into from
Jul 31, 2019

Conversation

saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Jul 31, 2019 •
edited
Loading

ref: #6014

@saadmk11 saadmk11 added the PR: work in progress Pull request is not ready for full review label Jul 31, 2019
@saadmk11 saadmk11 mentioned this pull request Jul 31, 2019
Closed
3 tasks
@saadmk11 saadmk11 removed the PR: work in progress Pull request is not ready for full review label Jul 31, 2019
@saadmk11 saadmk11 requested review from ericholscher and a team July 31, 2019 12:23
ericholscher
ericholscher approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 👍 We definitely need some UX around this, but this is at least a better approach.

@ericholscher ericholscher merged commit 55820c7 into readthedocs:master Jul 31, 2019
@stsewd stsewd mentioned this pull request Aug 1, 2019
Merged
@saadmk11 saadmk11 deleted the fix-social-account-issue branch August 1, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saadmk11 @ericholscher