Skip to content

Fix logic involving creation of Sphinx Domains #5997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 26, 2019
Merged

Fix logic involving creation of Sphinx Domains #5997

merged 5 commits into from
Jul 26, 2019

Conversation

dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Jul 25, 2019 •
edited
Loading

This is just a work around.
We should fix the original issue: #5821

@dojutsu-user dojutsu-user requested a review from a team July 25, 2019 20:00
ericholscher
ericholscher approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably use a test, if it's easy enough to test.

ericholscher
ericholscher approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test. 👍

@ericholscher ericholscher merged commit 6935ddf into readthedocs:master Jul 26, 2019
@dojutsu-user dojutsu-user deleted the add-more-loggers branch July 26, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd left review comments

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dojutsu-user @ericholscher @stsewd