Skip to content

Small Changes to PR Builder Code #5948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Small Changes to PR Builder Code #5948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
008051a
small updates
saadmk11 Jul 17, 2019
b3128ae
external version feature flag fix
saadmk11 Jul 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/guides/feature-flags.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ e.g. python-reno release notes manager is known to do that

``USE_TESTING_BUILD_IMAGE``: :featureflags:`USE_TESTING_BUILD_IMAGE`

``ENABLE_EXTERNAL_VERSION_BUILD``: :featureflags:`ENABLE_EXTERNAL_VERSION_BUILD`
``EXTERNAL_VERSION_BUILD``: :featureflags:`EXTERNAL_VERSION_BUILD`
2 changes: 1 addition & 1 deletion readthedocs/api/v2/views/footer_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from rest_framework_jsonp.renderers import JSONPRenderer

from readthedocs.api.v2.signals import footer_response
from readthedocs.builds.constants import LATEST, TAG, INTERNAL
from readthedocs.builds.constants import LATEST, TAG
from readthedocs.builds.models import Version
from readthedocs.projects.models import Project
from readthedocs.projects.version_handling import (
Expand Down
20 changes: 10 additions & 10 deletions readthedocs/builds/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,33 +62,33 @@
STABLE,
)

# GitHub Build Statuses
GITHUB_BUILD_STATE_FAILURE = 'failure'
GITHUB_BUILD_STATE_PENDING = 'pending'
GITHUB_BUILD_STATE_SUCCESS = 'success'

# General Build Statuses
BUILD_STATUS_FAILURE = 'failed'
BUILD_STATUS_PENDING = 'pending'
BUILD_STATUS_SUCCESS = 'success'

# GitHub Build Statuses
GITHUB_BUILD_STATUS_FAILURE = 'failure'
GITHUB_BUILD_STATUS_PENDING = 'pending'
GITHUB_BUILD_STATUS_SUCCESS = 'success'

# Used to select correct Build status and description to be sent to each service API
SELECT_BUILD_STATUS = {
BUILD_STATUS_FAILURE: {
'github': GITHUB_BUILD_STATE_FAILURE,
'github': GITHUB_BUILD_STATUS_FAILURE,
'description': 'The build failed!',
},
BUILD_STATUS_PENDING: {
'github': GITHUB_BUILD_STATE_PENDING,
'github': GITHUB_BUILD_STATUS_PENDING,
'description': 'The build is pending!',
},
BUILD_STATUS_SUCCESS: {
'github': GITHUB_BUILD_STATE_SUCCESS,
'github': GITHUB_BUILD_STATUS_SUCCESS,
'description': 'The build succeeded!',
},
}

RTD_BUILD_STATUS_API_NAME = 'continuous-documentation/read-the-docs'

GITHUB_EXTERNAL_VERSION_NAME = 'Pull Request'
GENERIC_EXTERNAL_VERSION_NAME = 'External Version'

RTD_BUILD_STATUS_API_NAME = 'continuous-documentation/read-the-docs'
2 changes: 1 addition & 1 deletion readthedocs/projects/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1407,7 +1407,7 @@ def add_features(sender, **kwargs):
SHARE_SPHINX_DOCTREE = 'share_sphinx_doctree'
DEFAULT_TO_MKDOCS_0_17_3 = 'default_to_mkdocs_0_17_3'
CLEAN_AFTER_BUILD = 'clean_after_build'
EXTERNAL_VERSION_BUILD = 'enable_external_version_build'
EXTERNAL_VERSION_BUILD = 'external_version_build'
UPDATE_CONDA_STARTUP = 'update_conda_startup'

FEATURES = (
Expand Down