Skip to content

update build status message for github #5947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 19, 2019
Merged

update build status message for github #5947

merged 3 commits into from
Jul 19, 2019

Conversation

saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Jul 17, 2019 •
edited
Loading

This will improve the mobile view as mobile view of github does not show the name of the service.

Before:

Screenshot from 2019-07-17 14-09-13

After:

Screenshot from 2019-07-17 14-08-07

@saadmk11 saadmk11 requested a review from ericholscher July 17, 2019 08:12
humitos
humitos approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!

@saadmk11
Copy link
Member Author

Resolved conflicts ::)

@ericholscher ericholscher merged commit d89d519 into readthedocs:gsoc-19-pr-builder Jul 19, 2019
@saadmk11 saadmk11 deleted the update-status-msg branch July 19, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

@humitos humitos humitos approved these changes

@stsewd stsewd stsewd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saadmk11 @ericholscher @humitos @stsewd