Merge the GSOC 2019 in-doc search changes #5919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will work after merging of #5848
stsewd
reviewed
Jul 16, 2019
Co-Authored-By: Santos Gallegos <[email protected]>
Fix spacing between the results and add highlight url param
Use `attrgetter` in sorted function
Co-Authored-By: Santos Gallegos <[email protected]>
Small improvement in parse_json
|
I believe this should be unblocked. We probably need to do a staged rollout though to rebuild the indexes. It look a long time last time to rebuild, and we can't ship the new search code before we have a new index because they are not backwards compatible. I will think a bit about the best approach here, but will probably need to take one of the servers out of the LB for this. |
|
Going to merge this once the tests pass 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merged the feature branch for the GSOC in-doc search project. The goal will be to get it deployed in the next couple weeks, and we'll have a couple more changes coming here, but it should definitely be reviewed by folks before going live.