Add check for external version in conf.py.tmpl for warning banner #5900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saadmk11
changed the title
stsewd
approved these changes
Jul 10, 2019
|
Blocking on this until we ship the extension also. |
humitos
approved these changes
Jul 11, 2019
|
The Extension was shipped, so this should not be blocked anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add a warning banner to external version docs.
To use this we need to add this in the requirements as its not merged
git+https://github.com/saadmk11/readthedocs-sphinx-ext/@external-version-warningSphinx Extension PR: readthedocs/readthedocs-sphinx-ext#72