Skip to content

Remove tags from the Version model #5864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2019
Merged

Remove tags from the Version model #5864

merged 1 commit into from
Jul 1, 2019

Conversation

ericholscher
Copy link
Member

This has never been used in any real way,
and is mostly just noise.

@ericholscher
Remove tags from the Version model
b4e2240 
This has never been used in any real way,
and is mostly just noise.
@ericholscher ericholscher requested a review from a team June 28, 2019 16:30
davidfischer
davidfischer approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@davidfischer davidfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did verify and there is production data in the DB for this. I don't think any of it matters though.

@ericholscher ericholscher merged commit 31d62e6 into master Jul 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the remove-version-tags branch July 1, 2019 20:25
@stsewd stsewd mentioned this pull request Jul 15, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfischer davidfischer davidfischer approved these changes

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericholscher @davidfischer @humitos