Skip to content

Add test for remote repo form #5842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2019
Merged

Add test for remote repo form #5842

merged 1 commit into from
Jun 25, 2019

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jun 24, 2019

With #5841 it was discovered an untested code

https://codecov.io/gh/rtfd/readthedocs.org/pull/5841/changes

this adds a proper test, actually I wasn't sure how to test this :)

@stsewd stsewd requested a review from a team June 25, 2019 00:42
ericholscher
ericholscher approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine 👍

@ericholscher ericholscher merged commit bfd57d3 into readthedocs:master Jun 25, 2019
@stsewd stsewd deleted the add-test-for-remote-repo-form branch June 25, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @ericholscher