Remove internal filtering from Version and Build listing

readthedocs/builds/views.py

@@ -92,7 +92,7 @@ def get_queryset(self):
             Project.objects.protected(self.request.user),
             slug=self.project_slug,
         )
-        queryset = Build.internal.public(
+        queryset = Build.objects.public(
             user=self.request.user,
             project=self.project,
         ).select_related('project', 'version')

readthedocs/projects/views/public.py

@@ -93,7 +93,7 @@ def get_context_data(self, **kwargs):
         context = super().get_context_data(**kwargs)
 
         project = self.get_object()
-        context['versions'] = Version.internal.public(
+        context['versions'] = Version.objects.public(
             user=self.request.user,
             project=project,
         )
@@ -268,7 +268,7 @@ def project_versions(request, project_slug):
         slug=project_slug,
     )
 
-    versions = Version.internal.public(
+    versions = Version.objects.public(
         user=request.user,
         project=project,
         only_active=False,

readthedocs/rtd_tests/tests/test_project_views.py

@@ -385,25 +385,18 @@ def test_project_download_media(self):
         response = self.client.get(url)
         self.assertEqual(response.status_code, 302)
 
-    def test_project_detail_view_only_shows_internal_versons(self):
+    def test_project_detail_view_shows_external_versons(self):
         url = reverse('projects_detail', args=[self.pip.slug])
         response = self.client.get(url)
         self.assertEqual(response.status_code, 200)
-        self.assertNotIn(self.external_version, response.context['versions'])
+        self.assertIn(self.external_version, response.context['versions'])
 
     def test_project_downloads_only_shows_internal_versons(self):
         url = reverse('project_downloads', args=[self.pip.slug])
         response = self.client.get(url)
         self.assertEqual(response.status_code, 200)
         self.assertNotIn(self.external_version, response.context['versions'])
 
-    def test_project_versions_only_shows_internal_versons(self):
-        url = reverse('project_version_list', args=[self.pip.slug])
-        response = self.client.get(url)
-        self.assertEqual(response.status_code, 200)
-        self.assertNotIn(self.external_version, response.context['active_versions'])
-        self.assertNotIn(self.external_version, response.context['inactive_versions'])
-
 
 class TestPrivateViews(MockBuildTestCase):
     def setUp(self):

readthedocs/rtd_tests/tests/test_views.py

@@ -278,7 +278,7 @@ def test_build_redirect(self, mock):
             '/projects/pip/builds/%s/' % build.pk,
         )
 
-    def test_build_list_does_not_include_external_versions(self):
+    def test_build_list_includes_external_versions(self):
         external_version = get(
             Version,
             project = self.pip,
@@ -295,5 +295,4 @@ def test_build_list_does_not_include_external_versions(self):
         )
         self.assertEqual(response.status_code, 200)
 
-        self.assertNotIn(external_version_build, response.context['build_qs'])
-        self.assertNotIn(external_version_build, response.context['active_builds'])
+        self.assertIn(external_version_build, response.context['build_qs'])