Remove PR Versions from Elasticsearch Indexing and HTMLFile Queryset Added #5805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readthedocs/search/documents.py
Outdated
| @@ -159,7 +160,7 @@ def get_queryset(self): | |||
| # Also do not index certain files | |||
| queryset = queryset.filter( | |||
| project__documentation_type__contains='sphinx' | |||
| ) | |||
| ).exclude(version__type=PULL_REQUEST) | |||
There was a problem hiding this comment.
can this not use the manager? If not, we should probably add a queryset method that does the same thing, so we can use it in cases like this.
There was a problem hiding this comment.
@ericholscher Added Queryset for this. Please have a look
saadmk11
changed the title
saadmk11
changed the title
saadmk11
force-pushed
the
remove-pr-from-es
branch
from
8d06f1f to
f8e9e99
Compare
saadmk11
force-pushed
the
gsoc-19-pr-builder
branch
from
28a23ac to
84a6975
Compare
saadmk11
force-pushed
the
remove-pr-from-es
branch
from
e971731 to
afd5e47
Compare
saadmk11
force-pushed
the
gsoc-19-pr-builder
branch
from
05951cf to
5a05b6c
Compare
|
This can now be updated against current |
ericholscher
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation from #5750