Fix tests on master #5769
Merged
Fix tests on master #5769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two PRs got merged and one modified the behaviour that the other one was depending on. This was giving an error in the lock creation because the base dir wasn't created yet. The rest of tests something I forgot to change project_pk -> version_pk (I did a grep, didn't find more)
|
Project's id and version's id are the same here (1), that's why tests didn't fail :) |
ericholscher
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two PRs got merged and one modified the behaviour that the
other one was depending on.
This was giving an error in the lock creation
because the base dir wasn't created yet.
The rest of tests something I forgot to change project_pk -> version_pk
(I did a grep, didn't find more)