Serve 404/index.html file for htmldir Sphinx builder #5754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
reviewed
Jun 3, 2019
| basepath, filename, fullpath = resolve_404_path(project, slug, language, tryfile) | ||
| if os.path.exists(fullpath): | ||
| log.debug( | ||
| 'serving 404.html page current version: [project: %s] [version: %s]', |
There was a problem hiding this comment.
('Serving %s ... ', tryfile, ...)
stsewd
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are serving a custom 404 page for those projects that have a
404.htmlon their docs root path. This produces projects usinghtmldirSphinx Builder to not serve custom 404 pages because this file is called404/index.html.This PR adds support for
htmldirSphinx Builder by trying first one file and if it does not exist try the other one.