-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Guide about custom 404 pages #5738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Small guide mentioning how Read the Docs find the 404.html file and suggesting sphinx-notfound-page to generate this HTML easily.
|
||
In case you don't want to deal with these links manually, | ||
or you want to use the same style for the 404 page than your theme in an easy way, | ||
you can use the `sphinx-notfound-page`_ extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we in the point to recommend the extension? I think there was some discussion to wait to have something solid fist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we are in that point now. We have been testing it for a while now in our own docs and there are people already using it. Also, it has tests and its own docs now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is after releasing v0.4, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few grammar cleanup things.
If we're happy w/ the extension, I'm happy to ship this 👍
Co-Authored-By: Eric Holscher <[email protected]>
1fd11cb
to
8444540
Compare
I accepted all the suggestions. Feel free to merge if you consider. |
@stsewd @ericholscher are we happy merging this at this point? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it! :)
Communicate to the users that adding a
404.html
in their root directory of the docs, will make Read the Docs to find it and serve it when a 404 happensAlso, suggest the usage of the
sphinx-notfound-page
extension.