Skip to content

Guide about custom 404 pages #5738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2019
Merged

Guide about custom 404 pages #5738

merged 2 commits into from
Jun 25, 2019

Conversation

humitos
Copy link
Member

@humitos humitos commented May 29, 2019

Communicate to the users that adding a 404.html in their root directory of the docs, will make Read the Docs to find it and serve it when a 404 happens

Also, suggest the usage of the sphinx-notfound-page extension.

Small guide mentioning how Read the Docs find the 404.html file and
suggesting sphinx-notfound-page to generate this HTML easily.

In case you don't want to deal with these links manually,
or you want to use the same style for the 404 page than your theme in an easy way,
you can use the `sphinx-notfound-page`_ extension.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we in the point to recommend the extension? I think there was some discussion to wait to have something solid fist.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we are in that point now. We have been testing it for a while now in our own docs and there are people already using it. Also, it has tests and its own docs now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is after releasing v0.4, though.

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few grammar cleanup things.

If we're happy w/ the extension, I'm happy to ship this 👍

@humitos humitos requested review from ericholscher and stsewd June 12, 2019 11:59
Co-Authored-By: Eric Holscher <[email protected]>
@humitos humitos force-pushed the humitos/custom-404-docs branch from 1fd11cb to 8444540 Compare June 12, 2019 12:00
@humitos
Copy link
Member Author

humitos commented Jun 12, 2019

I accepted all the suggestions. Feel free to merge if you consider.

@humitos
Copy link
Member Author

humitos commented Jun 25, 2019

@stsewd @ericholscher are we happy merging this at this point?

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it! :)

@ericholscher ericholscher merged commit 87f65a4 into master Jun 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the humitos/custom-404-docs branch June 25, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants