Simplify update docs task #5694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have a lot of nested try..exception blocks. We only need one, we are duplicating the same error handling. Also, we are already do checks to avoid ending with undefined variables.
|
I'm guessing we added the two try..exc blocks because of #5678 but now it's fixed. |
humitos
requested changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a lot of nested try..exception blocks.
We only need one, we are duplicating the same error handling.
Also, we are already do checks to avoid ending with undefined variables.
I refactored to run
run_buildafterrun_setupin the same try...exc block. The exception handling is the same, so it came be removed.