Run checkout inside docker

[stsewd]

The title isn't 100% true,
because it depends on the settings (if docker is enabled).
There are still commands being executed outside docker #5673.

Blocked on #5673
Related to #5672

[humitos]

Is this strictly blocked on #5673? I think these are separate things and we can start running these commands from inside the container and then migrate the rest once we have made a decision.

Although, before merging this PR we should make a PR compatible with the Corporate site.

[stsewd]

Yeah, this isn't really blocked, but it feels weird executing the same set of commands in different environments. It could lead to some surprises using different git daemons? I don't know. Better safe than sorry? p:

[humitos]

It could lead to some surprises using different git daemons?

This is a good point, yes. I'm not sure if we have the same git version inside the container than outside.

[stsewd]

According to #5673 (comment) is it ok to merge this right now?

[humitos]

I just realized that executing git from inside the container may requires another change as well. On which servers could be sync_repository_task executed when triggered? If the answer includes webXX we may need to limit it the builder queue because web servers do not have docker.

[ericholscher]

This seems really simple, why weren't we doing this before? I feel like there must have been a reason.

[humitos]

This PR seems to remove the docker= attribute that receive the method and make usage of settings.DOCKER_ENABLED instead. Is that all? If so, I think we can safely merge it, right?

[stsewd]

@humitos we can't merge this till we can retrieve the git data from inside the container.

[humitos]

This PR was superseded by #6436. Feel free to re-open if it's still valid.