-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Gold project sponsorship changes #5628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
davidfischer
commented
Apr 24, 2019
- new gold users can no longer sponsor projects
- applies to gold users created after 2019-05-01
- new gold users can no longer sponsor projects - applies to gold users created after 2019-05-01
Shouldn't we use a time based feature flag for this? |
Feature flags apply to projects, correct? This applies to the user subscription. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I left a comment about the message. Although, it's not a blocker on the PR. We can make the change later if we think it's better.
<p class="empty"> | ||
{% blocktrans trimmed %} | ||
<strong>Note:</strong> this is a legacy feature. | ||
New gold members cannot sponsor projects to be ad-free. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't feel good to me to expose this to new gold users.
I'm not sure what's best here, but maybe removing this page completely for new gold users is better, instead of showing them that they could have sponsored their projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on the fence about whether to include it, but I do think we should probably prompt them to email us here about removing ads if they want as well. Or perhaps some other messaging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't feel good to me to expose this to new gold users.
The page is removed for new gold users. New users will be redirected. This message is shown only to older gold users to let them know that we no longer do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! 💯
New condition makes sense to me. |