Fix extra origin in urls #5523
Merged
Fix extra origin in urls #5523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`verbose_name` is unique in each project, because we only have one remote. `identifier` includes origin for branches and also it can point to the same commit in tags. Fixes readthedocs#5518
|
Looks like this is going to need a little more of work, the cases of |
stsewd
removed
the
PR: work in progress
|
This is ready for review |
ericholscher
approved these changes
Mar 27, 2019
This was referenced May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verbose_nameis unique in each project, because we only have one remote.identifierincludes origin for branches and also it can point to thesame commit in tags.
Fixes #5518