Skip to content

Added note warning about using sqlite 3.26.0 in development #5491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2019
Merged

Added note warning about using sqlite 3.26.0 in development #5491

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56be497
Added note warning about using sqlite 3.26.0 in development
rshrc Mar 19, 2019
c887d41
Change note to warning
ericholscher Mar 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/install.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ First, obtain `Python 3.6`_ and virtualenv_ if you do not already have them.
Using a virtual environment is strongly recommended,
since it will help you to avoid clutter in your system-wide libraries.

.. note::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be a warning instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd really like to keep these edge cases out of the default flow for the install guide, otherwise it just gets messy. We should add them to a troubleshooting section at the bottom of the guide, with the error that they fix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is that it's not an edge case.

All users installing Python 3.6 with an up to date system will hit this problem. The issue is fixed on Django 2.x but we are using 1.11.x. So, all new contributors will hit it until we upgrade our django version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks sense then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks sense then.


Currently the recommended version of python is Python 3.6.7. Which uses a
lower version of sqlite3. The next version of Python can be used when the
project starts using the latest Django version.

Additionally Read the Docs depends on:

* `Git`_ (version >=2.17.0)
Expand Down