Skip to content

Fix inconsistency in footer links #5454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2019
Merged

Fix inconsistency in footer links #5454

merged 2 commits into from
Mar 13, 2019

Conversation

dojutsu-user
Copy link
Member

Closes #5449

stsewd
stsewd reviewed Mar 13, 2019
View reviewed changes
readthedocs/templates/base.html Outdated
@@ -151,19 +151,19 @@ <h4>{% trans 'Get Involved' %}</h4>

<ul>
<li>
<a href="https://docs.readthedocs.io/en/latest/getting_started.html">{% trans 'Getting Started Guide' %}</a>
<a href="https://docs.readthedocs.io/page/getting_started.html">{% trans 'Getting Started Guide' %}</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this page redirects to /intro/getting-started-with-sphinx.html

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed the changes.
Thanks.

stsewd
stsewd approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

davidfischer
davidfischer approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@davidfischer davidfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me too.

I think there are some additional templates where we could do the same throughout the repository if you're feeling ambitious!

@dojutsu-user
Copy link
Member Author

@davidfischer
I would like to update this. There are many places where the link is pointed to latest version.
Will update this PR to point them at stable version.

@stsewd
Copy link
Member

stsewd commented Mar 13, 2019

@dojutsu-user please open a new PR, so it's easy to review, I'm merging this one.

@stsewd stsewd merged commit 8607c7e into readthedocs:master Mar 13, 2019
@dojutsu-user dojutsu-user deleted the consistency-in-links branch March 13, 2019 23:10
@dojutsu-user dojutsu-user mentioned this pull request Mar 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfischer davidfischer davidfischer approved these changes

@stsewd stsewd stsewd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dojutsu-user @stsewd @davidfischer