Check for two paths for each file #5370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because HTMLDir can generate a file from two different places: * foo.rst * foo/index.rst Both lead to `foo/index.html` refs #5368
stsewd
approved these changes
Feb 27, 2019
|
Yea, the footer should have FS access, but we're talking about having that go away here soon too :/ |
Do you mean the footer api? but the version selector is great! |
|
No, the filesystem access on the webs :) |
|
Works locally:
|
|
You should check the api response, because when we don't have results, we fallback to sphinx. But it should work with this logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because HTMLDir can generate a file from two different places:
Both lead to
foo/index.htmlfixes #5368