Require conda.file when using conda in v1 #5338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some people are migrating from pip to conda, but they were using a v1 config, then when migrating they are using the conda option from v2. We are not validating this, but using conda.file is mandatory when using the conda option (or rtd will fail without any reason). Close readthedocs#5322 Close readthedocs#5228
ericholscher
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people are migrating from pip to conda,
but they were using a v1 config,
then when migrating they are using the conda option from v2 (which is called
conda.environment)We are not validating this, but using conda.file is mandatory
when using the conda option in v1 (or rtd will fail without any reason).
Close #5322
Close #5228