Skip to content

Downgrade pytest-django #5294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 19, 2019
Merged

Downgrade pytest-django #5294

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0849354
Downgrade test requirements
stsewd Feb 14, 2019
ccc5440
Downgrade only django-pytest
stsewd Feb 14, 2019
0502b43
The final combination
stsewd Feb 15, 2019
a4430fd
Comment
stsewd Feb 19, 2019
36dc0e7
Merge branch 'master' into downgrade-test-req
stsewd Feb 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions requirements/testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@
-r local-docs-build.txt

django-dynamic-fixture==2.0.0
pytest==4.2.0
pytest-django==3.4.7
# pytest 4.2 is incompatible with pytest-django 3.4.6
pytest==4.1.1 # pyup: <4.2
# pytest-django 3.4.7 break our tests
pytest-django==3.4.6 # pyup: <3.4.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs to say where is the problem, since upgrading these packages won't produce any error in the community site and we will upgrade them again.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fail in the symlinks file if I remember correctly, but the stacktrace is really verbose, it can't even be displayed in my terminal.

I think I researched a little more and the problem was related to overriding the settings from django and not being restarted between some tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I think the problem wasn't in that file, but when other tests run before that, still tricky to replicate

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only way I can think is linking to this PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to link to this PR in the comment, add the explanation about why this package can't be upgraded without checking that corporate tests are passing first.

pytest-xdist==1.26.1
pytest-cov==2.6.1
apipkg==1.5
Expand Down