Skip to content

Use the embed API to show search results inline #5292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 28 commits into from

Conversation

ericholscher
Copy link
Member

This is a work in progress,
just showing what can be done.

Refs #1812

This removes the second entry point to site search, and unifies all our searching to use fancy facets and be nice.
This is a work in progress,
just showing what can be done.
@ericholscher ericholscher added the PR: work in progress Pull request is not ready for full review label Feb 14, 2019
@stale
Copy link

stale bot commented Apr 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Apr 15, 2019
@stsewd stsewd removed the Status: stale Issue will be considered inactive soon label Apr 15, 2019
@stale
Copy link

stale bot commented May 30, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label May 30, 2019
@ericholscher ericholscher removed the Status: stale Issue will be considered inactive soon label May 31, 2019
@ericholscher
Copy link
Member Author

Closing this, as @humitos has a neat example of this working elsewhere.

@humitos
Copy link
Member

humitos commented Jun 7, 2019

Just for the records, it's at https://github.com/humitos/sphinx-hoverxref, still Work In Progress though. I does not touches the backend as your example and only works for :ref: directive. To be expanded for intersphinx there are probably more work to do and use the backend modeling that you added in another PR.

@stsewd stsewd deleted the search-embed-api branch September 15, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: work in progress Pull request is not ready for full review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants