Skip to content

Allow to override trigger_build from demo project #5236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2019
Merged

Allow to override trigger_build from demo project #5236

merged 3 commits into from
Feb 12, 2019

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Feb 5, 2019

This is to fix a case in the corporate site

@stsewd
Allow to override trigger_build from demo project
c54e800 
This is to fix a case in the corporate site
@stsewd stsewd requested a review from a team February 5, 2019 18:47
humitos
humitos reviewed Feb 5, 2019
View reviewed changes
ericholscher
ericholscher approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@ericholscher ericholscher merged commit 99c31d6 into master Feb 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the stsewd/allow-to-override-trigger-demo-import branch February 12, 2019 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos left review comments

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stsewd @ericholscher @humitos