Version page should show build status + not being able to pick a non-built doc #5169
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # -*- coding: utf-8 -*- | ||
|
|
||
| from django import template | ||
|
|
||
|
|
||
| register = template.Library() | ||
|
|
||
|
|
||
| @register.simple_tag | ||
| def is_latest_built_success(version): | ||
| """ | ||
| Checks the build status of the passed version. | ||
|
|
||
| Returns true if the latest build for the ``version`` | ||
| is success else returns false. Returns None if no | ||
| build is found for the given version. | ||
| """ | ||
| res = version.builds.all().order_by('-date').values_list('success', flat=True) | ||
| if res.exists(): | ||
| return res.first() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ | |
| {% load privacy_tags %} | ||
| {% load gravatar %} | ||
| {% load projects_tags %} | ||
| {% load builds_tags %} | ||
|
|
||
| <div id="project_details"> | ||
| <div class="wrapper"> | ||
|
|
@@ -41,6 +42,16 @@ <h3>{% trans "Versions" %}</h3> | |
| {% if request.user|is_admin:project %} | ||
| <ul class="module-item-menu"> | ||
| <li><a href="{% url "project_version_detail" project.slug version.slug %}">{% trans "Edit" %}</a></li> | ||
| <li> | ||
| <span class="right quiet status-middle"> | ||
| {% is_latest_built_success version as is_success %} | ||
|
There was a problem hiding this comment. This should use this model method: https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/projects/models.py#L882 -- it's likely much more efficient. There was a problem hiding this comment.
|
||
| {% if is_success %} | ||
| <span class="build-state build-state-passing">{% trans "passing" %}</span> | ||
| {% else %} | ||
| <span class="build-state build-state-failing status-failing">{% trans "failing" %}</span> | ||
| {% endif %} | ||
| </span> | ||
| <li> | ||
| </ul> | ||
| {% endif %} | ||
| </li> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't use pixel margins like this, we can't guarantee the difference is 14px -- font differences, font size differences, and translated strings will all produce something other than 14px. the proper way to do this is to use a fixed block size as a parent element, which is independent of the text we're trying to separate. But there are still issues with translations in this case, so I'm generally against trying to fit more information into a coulmn format and that is why our design project is moving towards a multi-line row format for all tabular data like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, there are already styles for adding multiple elements in a single row like this, however you'll have to search for an example, I don't have one available. There are several dashboard forms that already use a three column approach.