Remove unused code for reducing logging to sentry. #5073
Conversation
| subclasses of BuildEnvironmentException. For | ||
| :py:class:`BuildEnvironmentWarning`, exit this context gracefully, but | ||
| don't mark the build as a failure. For all other exception classes, | ||
| If the exception's type is :py:class:`BuildEnvironmentWarning`, |
There was a problem hiding this comment.
I think we still want to communicate here that all subbclasses of the Warning exception won't mark the build as failure.
| self.failure = exc_value | ||
| else: | ||
| log_level_function = log.error | ||
| if not issubclass(exc_type, BuildEnvironmentWarning): | ||
| self.failure = exc_value |
There was a problem hiding this comment.
I think we do want to log the BuildEnvironmentWarning ones as a log.warning, but it seems that you remove all the log. calls.
There was a problem hiding this comment.
Yes.
I thought the task.throws is already logging them and then we again log them here, so it is kind of redundant.
However, I think that this PR is no longer required after #5118 .
Would like to know your views on this.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
After #5054 got merged. The code used for reducing logging to sentry can be removed.
Related Issue: #4590
Related Comments: #1