Raise exception in failed checkout #5035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure is bc we don't have tests for bzr |
humitos
reviewed
Dec 26, 2018
| @@ -47,6 +47,10 @@ class RepositoryError(BuildEnvironmentError): | |||
| 'You can not have two versions with the name latest or stable.' | |||
| ) | |||
|
|
|||
| FAILED_TO_CHECKOUT = _( | |||
| 'Failed to checkout revision: {}' | |||
There was a problem hiding this comment.
Will this exception log to Sentry? It should not.
There was a problem hiding this comment.
I don't think so. Actually I'm not sure, I haven't seen a RepositoryError in sentry
There was a problem hiding this comment.
There are some,
https://sentry.io/read-the-docs/readthedocs-org/issues/713027767/?query=RepositoryError
There are some places where it's handled
and there other where it's not:
I suppose that this is the final solution, #3856
There was a problem hiding this comment.
Going to merge this, and if it logs, we can handle it later.
ericholscher
approved these changes
Jan 10, 2019
| @@ -47,6 +47,10 @@ class RepositoryError(BuildEnvironmentError): | |||
| 'You can not have two versions with the name latest or stable.' | |||
| ) | |||
|
|
|||
| FAILED_TO_CHECKOUT = _( | |||
| 'Failed to checkout revision: {}' | |||
There was a problem hiding this comment.
Going to merge this, and if it logs, we can handle it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5033