Skip to content

Show current executing command in build report #5019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Dec 19, 2018

Closes #4288

Still need to figure out some cases and clean up a little, but this is kind of working right now.

@stsewd stsewd added the PR: work in progress Pull request is not ready for full review label Dec 19, 2018
@stsewd
Copy link
Member Author

stsewd commented Dec 20, 2018

So, there is a little problem with the start_time var, I think I'm going to add the save & update as hooks for BuildCommand, something similar to what I was doing in #3687

@stsewd stsewd mentioned this pull request Dec 21, 2018
@stsewd
Copy link
Member Author

stsewd commented Dec 21, 2018

Another problem right now, the last command doesn't get expanded, I have no idea why :/

@stale
Copy link

stale bot commented Feb 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Feb 16, 2019
@stale stale bot closed this Feb 23, 2019
@stsewd stsewd reopened this Feb 24, 2019
@stale stale bot removed the Status: stale Issue will be considered inactive soon label Feb 24, 2019
@stale
Copy link

stale bot commented Apr 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Apr 10, 2019
@humitos
Copy link
Member

humitos commented Apr 10, 2019

How close is this to get this merged? It seems there are other problems that are blocking this PR.

I like the feature, but I think we won't spend too much time on it right now. I'd say to put the last effort if we are close to merge it. Otherwise, close it for now.

@stale stale bot removed the Status: stale Issue will be considered inactive soon label Apr 10, 2019
@stsewd
Copy link
Member Author

stsewd commented Apr 11, 2019

Well, it's a cool feature. There are some problems with the js part to resolve, not sure if someone is interesting in touching the js part, I couldn't find a easy way to debug it with knockoutjs

@stsewd stsewd closed this Apr 11, 2019
@stsewd stsewd deleted the show-current-command-on-build-report branch April 11, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: work in progress Pull request is not ready for full review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants