Allow large form posts via multipart encoded forms to command API

readthedocs/doc_builder/environments.py

@@ -22,12 +22,14 @@
 from docker.errors import APIError as DockerAPIError
 from docker.errors import DockerException
 from requests.exceptions import ConnectionError
+from requests_toolbelt.multipart.encoder import MultipartEncoder
 from slumber.exceptions import HttpClientError
 
 from readthedocs.builds.constants import BUILD_STATE_FINISHED
 from readthedocs.builds.models import BuildCommandResultMixin
 from readthedocs.core.utils import slugify
 from readthedocs.projects.constants import LOG_TEMPLATE
+from readthedocs.projects.models import Feature
 from readthedocs.restapi.client import api as api_v2
 
 from .constants import (
@@ -224,7 +226,25 @@ def save(self):
             'start_time': self.start_time,
             'end_time': self.end_time,
         }
-        api_v2.command.post(data)
+
+        if self.build_env.project.has_feature(Feature.API_LARGE_DATA):
+            # Don't use slumber directly here. Slumber tries to enforce a string,
+            # which will break our multipart encoding here.
+            encoder = MultipartEncoder(
+                {key: str(value) for key, value in data.items()}
+            )
+            resource = api_v2.command
+            resp = resource._store['session'].post(
+                resource._store['base_url'] + '/',
+                data=encoder,
+                headers={
+                    'Content-Type': encoder.content_type,
+                }
+            )
+            log.info('Post response via multipart form: %s', resp)
+        else:
+            resp = api_v2.command.post(data)
+            log.info('Post response via JSON encoded data: %s', resp)
 
 
 class DockerBuildCommand(BuildCommand):

readthedocs/projects/models.py

@@ -1010,6 +1010,7 @@ def add_features(sender, **kwargs):
     DONT_OVERWRITE_SPHINX_CONTEXT = 'dont_overwrite_sphinx_context'
     ALLOW_V2_CONFIG_FILE = 'allow_v2_config_file'
     MKDOCS_THEME_RTD = 'mkdocs_theme_rtd'
+    API_LARGE_DATA = 'api_large_data'
 
     FEATURES = (
         (USE_SPHINX_LATEST, _('Use latest version of Sphinx')),
@@ -1022,6 +1023,7 @@ def add_features(sender, **kwargs):
         (ALLOW_V2_CONFIG_FILE, _(
             'Allow to use the v2 of the configuration file')),
         (MKDOCS_THEME_RTD, _('Use Read the Docs theme for MkDocs as default theme')),
+        (API_LARGE_DATA, _('Try alternative method of posting large data'))
     )
 
     projects = models.ManyToManyField(

readthedocs/restapi/views/model_views.py

@@ -11,6 +11,7 @@
 from django.shortcuts import get_object_or_404
 from django.template.loader import render_to_string
 from rest_framework import decorators, permissions, status, viewsets
+from rest_framework.parsers import MultiPartParser, JSONParser, FormParser
 from rest_framework.renderers import BaseRenderer, JSONRenderer
 from rest_framework.response import Response
 
@@ -235,6 +236,7 @@ class BuildViewSet(SettingsOverrideObject):
 
 
 class BuildCommandViewSet(UserSelectViewSet):
+    parser_classes = [JSONParser, MultiPartParser]
     permission_classes = [APIRestrictedPermission]
     renderer_classes = (JSONRenderer,)
     serializer_class = BuildCommandSerializer