-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Remove LOCAL_GIT_BRANCHES
from settings
#4993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LOCAL_GIT_BRANCHES
from settings
#4993
Conversation
This is only needed with branches, tags are fine. |
Python2 again :( |
Codecov Report
@@ Coverage Diff @@
## master #4993 +/- ##
==========================================
- Coverage 76.76% 76.74% -0.02%
==========================================
Files 158 158
Lines 9953 9951 -2
Branches 1245 1244 -1
==========================================
- Hits 7640 7637 -3
Misses 1980 1980
- Partials 333 334 +1
|
Failure is only related to global coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. I probably should have figured out how to do it at the time, but this is a better solution than I had :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! I like those comments in the code ;)
We could make those 3 steps a method or a function maybe if we think that we are going to use it normally.
Closes #4985