-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add admin interface for reindexing a project search #4992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add admin interface for reindexing a project search #4992
Conversation
This PR is in very initial phase. |
Codecov Report
@@ Coverage Diff @@
## master #4992 +/- ##
=========================================
- Coverage 76.76% 76.7% -0.06%
=========================================
Files 158 158
Lines 9953 9965 +12
Branches 1245 1246 +1
=========================================
+ Hits 7640 7644 +4
- Misses 1980 1988 +8
Partials 333 333
|
Codecov Report
@@ Coverage Diff @@
## master #4992 +/- ##
==========================================
- Coverage 77.04% 76.33% -0.71%
==========================================
Files 158 158
Lines 10108 10021 -87
Branches 1274 1250 -24
==========================================
- Hits 7788 7650 -138
- Misses 1989 2037 +48
- Partials 331 334 +3
|
I think we should keep the management command because it is used in these tests
|
@agjohnson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good addition. We should simplify the admin actions so they are just wrappers around a small utility function that does the logic. It will make it easier to maintain, and also port to our upgraded search (once we figure out how to ship it)
@ericholscher |
You should be able to call https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/search/signals.py#L44 |
Here is a bit of a snippet:
|
@ericholscher |
Closing this. |
Related issue - #4654
Drop management command, these aren't good interfaces for site admins and are mostly hidden