Add test case for send_notifications on VersionLockedError

[dojutsu-user]

Fixes #4840
This test checks that no notification is sent if the Version is locked.

[dojutsu-user]

I am not able to write test for it. Any help would be nice.

[codecov]

Codecov Report

Merging #4958 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4958      +/-   ##
==========================================
+ Coverage    76.8%   76.84%   +0.04%     
==========================================
  Files         158      158              
  Lines        9937     9937              
  Branches     1241     1241              
==========================================
+ Hits         7632     7636       +4     
+ Misses       1973     1971       -2     
+ Partials      332      330       -2

Impacted Files	Coverage Δ
readthedocs/projects/tasks.py	71.4% <0%> (+0.2%)	⬆️
readthedocs/doc_builder/environments.py	87.87% <0%> (+0.8%)	⬆️

[stsewd]

I'm not sure what you mean, I already see a test here. If you mean the codecov failure, that is because of the test code, you can see the codecov report here https://codecov.io/gh/rtfd/readthedocs.org/pull/4958/diff (the lines with dark red marks are missing coverage)

[dojutsu-user]

@stsewd
The test in this PR is not working as of now (that test is my attemp to write the required test)
Actually I wanted to test these lines

https://github.com/rtfd/readthedocs.org/blob/50bb883769328afc33a699ff93d9ccd8488ad1b1/readthedocs/projects/tasks.py#L472-L477

[dojutsu-user]

I think, it's ready for review.

[RichardLitt]

@agjohnson Can you explicitly specify what information you need before reviewing this?

[ericholscher]

This looks 💯