Remove project_version_delete_html view
#4950
Conversation
We used to have a "Clean" button in the Inactive Versions listing to remove built and disabled versions of the documentation. This is not more possible, because when the version is disabled (mark as non active) we call `clean_artifacts` and remove all the HTML files for this version and mark it as `Version.build=False`. In the end, that button does not appear anymore. Related #4937
humitos
force-pushed
the
humitos/versions/clean
branch
from
d362a11 to
7982459
Compare
Codecov Report
@@ Coverage Diff @@
## master #4950 +/- ##
==========================================
+ Coverage 76.93% 76.96% +0.02%
==========================================
Files 158 158
Lines 10039 10030 -9
Branches 1259 1258 -1
==========================================
- Hits 7724 7720 -4
+ Misses 1981 1977 -4
+ Partials 334 333 -1
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4950 +/- ##
==========================================
+ Coverage 76.93% 76.96% +0.02%
==========================================
Files 158 158
Lines 10039 10030 -9
Branches 1259 1258 -1
==========================================
- Hits 7724 7720 -4
+ Misses 1981 1977 -4
+ Partials 334 333 -1
|
|
Mmm, actually I have seen this button before. And yes, the docs are still online.
|
|
@stsewd is that project very old? I think it's not possible to see that button with the current code in production. Do you know what would be the steps to see that Clean button currently? |
|
Not sure how to replicate this :/ |
|
There are likely cases where Celery fails to execute for some reason, eg. if we're restarting it in the middle of a task or similar. |
|
@ericholscher from your comment, I suppose that we want to keep this code here and close this PR. If that's what you mean, please go ahead. |
|
I'm of mixed feelings. I don't think it's super important to keep, but I don't see much value in deleting it either. I think we can keep it until we totally rethink how we handle our HTML uploads, and then it will be deprecated & removed at that point. |
We used to have a "Clean" button in the Inactive Versions listing to remove built and disabled versions of the documentation.
This is not more possible, because when the version is disabled (mark as non active) we call
clean_artifactsand remove all the HTML files for this version and mark it asVersion.build=False. In the end, that button does not appear anymore.Related #4937