-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Remove deprecated sudo from travis #4919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4919 +/- ##
==========================================
- Coverage 76.75% 75.61% -1.14%
==========================================
Files 158 158
Lines 10048 10048
Branches 1265 1265
==========================================
- Hits 7712 7598 -114
- Misses 1995 2132 +137
+ Partials 341 318 -23
|
Oh, we can use |
I'm not sure why ES isn't working on xenial :/ @safwanrahman any ideas here? Maybe we can follow this steps now? https://docs.travis-ci.com/user/database-setup/#installing-specific-versions-of-elasticsearch |
@stsewd I am hoping to get the ES6 merged, so we can rebase and check if the new version is also failing. |
Got it, we have till december 7th, if not, I can revert the xenial update and just remove |
I think I know where the problem is, we need java7
|
c7cdb88
to
3ce197d
Compare
I was unable to install java7 on travis to make ES work :/, I'm just back to removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
Is there anything missing here or we can merge it as is? |
Nope, we can merge this |
It will be removed soon
https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration