-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Expose environment variables from database into build commands #4894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Environment variables can be added from the Admin and they will be used when running build commands. All the variables for that particular project will be expose to all the commands.
If this is the path that we want to follow, I'd add tests for this new code. |
This doesn't close, #3992. It only wraps up the first phase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I think this is close, there were just some implementation details to firm up.
readthedocs/projects/migrations/0034_add_environment_variables.py
Outdated
Show resolved
Hide resolved
Add the `environment_variables` field to this serializer that will be returned only when the user is admin.
Codecov Report
@@ Coverage Diff @@
## master #4894 +/- ##
==========================================
+ Coverage 76.6% 76.65% +0.05%
==========================================
Files 158 158
Lines 10043 10057 +14
Branches 1268 1269 +1
==========================================
+ Hits 7693 7709 +16
+ Misses 2008 2007 -1
+ Partials 342 341 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look great! 💯
I'm not sure any of this feedback is necessary, but opened up for discussion at least.
🎉 |
Environment variables can be added from the Admin and they will be used when running build commands. All the variables for that particular project will be expose to all the commands.
I QA this under Docker and Local building and my custom env variable was exposed in both scenarios.