Shorten project name to match slug length #4856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the just-merged migration to handle name as well
|
We shouldn't even hit this migration in prod: |
stsewd
approved these changes
Nov 2, 2018
| @@ -80,7 +80,7 @@ class Project(models.Model): | |||
| # Generally from conf.py | |||
| users = models.ManyToManyField(User, verbose_name=_('User'), | |||
| related_name='projects') | |||
| name = models.CharField(_('Name'), max_length=255) | |||
| name = models.CharField(_('Name'), max_length=63) | |||
| # A DNS label can contain up to 63 characters. | |||
There was a problem hiding this comment.
Maybe is worth to move the comment above, so it covers both, name and slug?
|
Looks like the migration check wants to see a new migration file |
Codecov Report
@@ Coverage Diff @@
## master #4856 +/- ##
=======================================
Coverage 76.41% 76.41%
=======================================
Files 158 158
Lines 9990 9990
Branches 1262 1262
=======================================
Hits 7634 7634
Misses 2016 2016
Partials 340 340
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the just-merged migration to handle name as well