-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Delete untracked tags on fetch #4811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete untracked tags on fetch #4811
Conversation
Travis is building with ubuntu 14, so we have |
Interesting, I didn't realize Travis was on such an old Ubuntu. Not sure the best approach -- I wonder if we can install a newer git on Travis or something. |
Codecov Report
@@ Coverage Diff @@
## master #4811 +/- ##
=======================================
Coverage 76.33% 76.33%
=======================================
Files 158 158
Lines 9968 9968
Branches 1258 1258
=======================================
Hits 7609 7609
Misses 2018 2018
Partials 341 341
|
9921e9e
to
64b8e09
Compare
Someone from the travis team pointed me out that we can use just apt-get 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! 😍
@@ -1,21 +1,33 @@ | |||
# -*- coding: utf-8 -*- | |||
|
|||
from __future__ import ( | |||
absolute_import, division, print_function, unicode_literals) | |||
absolute_import, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are deprecating Python2 we should remove these imports and also configure .isort to not add them anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened readthedocs/common#19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Confirmed we have |
|
||
# We still have all branches and tags in the local repo | ||
self.assertEqual( | ||
set(['v01', 'v02']), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that I wrote this code... I should have written {'v01', 'v02'}
🤷♂️
I see the |
Close #4258
We are using ubuntu 18.04 on both community and commercial sites, so we are good to use this feature available on
git>=2.17.0
https://git-scm.com/docs/git-fetch/2.17.0#git-fetch---prune-tags