Do not fail when unlinking an non-existing path #4760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we try to unlink a path that doesn't exist, we need to do nothing instead of failing hard and logging an exception on Sentry.
ericholscher
approved these changes
Oct 16, 2018
readthedocs/core/symlink.py
Outdated
| @@ -63,7 +63,7 @@ | |||
|
|
|||
| from readthedocs.builds.models import Version | |||
| from readthedocs.core.utils.extend import SettingsOverrideObject | |||
| from readthedocs.core.utils import safe_makedirs | |||
| from readthedocs.core.utils import safe_makedirs, unlink | |||
There was a problem hiding this comment.
Should this be called safe_unlink to mirror the safe_makedirs and show it has a bit more error handling?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we try to unlink a path that doesn't exist, we need to do nothing instead of failing hard and logging an exception on Sentry.
This has generated more than 6.5k Sentry logs.