Skip to content

Improve unexpected error message when build fails #4754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 1, 2018
Merged

Improve unexpected error message when build fails #4754

merged 3 commits into from
Nov 1, 2018

Conversation

dojutsu-user
Copy link
Member

Fixes #4751

@RichardLitt
Copy link
Member

Thanks for your first PR, @dojutsu-user! One of the maintainers will get to this soon.

humitos
humitos reviewed Oct 15, 2018
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment for the English grammar.

If you think it's acceptable, we need to do the same in the other two places.

readthedocs/doc_builder/exceptions.py Outdated
'Please report this to us with your build id ({build_id}).',
'Please try again later. '
'However, if this problem persists, '
'please report to us with your build id ({build_id}).',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I said "please report this to us".

I'm not sure if that was important for the grammar, but I just wanted to mention it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay.... that looks more good to me too.

@dojutsu-user
Copy link
Member Author

@humitos I have corrected the grammar. Please review

humitos
humitos approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This is ready to be merged from my point of view!

@humitos humitos requested a review from davidfischer November 1, 2018 10:45
@humitos
Copy link
Member

humitos commented Nov 1, 2018

I'm requesting @davidfischer eyes since he is better than myself with English grammar and communication.

@RichardLitt
Copy link
Member

Looks fine to me. :)

@ericholscher
Copy link
Member

💯 Thanks!

@ericholscher ericholscher merged commit fb1fef9 into readthedocs:master Nov 1, 2018
@dojutsu-user dojutsu-user deleted the change-error-msg-when-build-failed branch December 12, 2018 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

@RichardLitt RichardLitt RichardLitt approved these changes

@davidfischer davidfischer Awaiting requested review from davidfischer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dojutsu-user @RichardLitt @humitos @ericholscher