Remove /cname endpoint #4731
Merged
Remove /cname endpoint #4731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
commented
Oct 4, 2018
| @@ -65,7 +65,6 @@ | |||
| function_urls = [ | |||
| url(r'embed/', core_views.embed, name='embed'), | |||
There was a problem hiding this comment.
This one isn't used either, and it doesn't work
There was a problem hiding this comment.
Yea, we should kill this. We have the embed in our ext repo that actually does work:
https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/urls.py#L117
stsewd
commented
Oct 4, 2018
| def cname_to_slug(host): | ||
| # TODO: remove |
There was a problem hiding this comment.
Need to remove this after #4730
ericholscher
approved these changes
Oct 16, 2018
| @@ -65,7 +65,6 @@ | |||
| function_urls = [ | |||
| url(r'embed/', core_views.embed, name='embed'), | |||
There was a problem hiding this comment.
Yea, we should kill this. We have the embed in our ext repo that actually does work:
https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/urls.py#L117
Closed
|
I just wanted to do all the removal here p: there is nothing blocking this, I can do the removal in the other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't used or documented, it was added here 3cada1d
This should be merged after #4730
Related #1991 (comment)