-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix the form for adopting a project #4721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ericholscher
merged 16 commits into
readthedocs:master
from
dojutsu-user:gold-member-add-project-form
Oct 17, 2018
Merged
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
92e5142
Fix the form for adding a project for gold members
dojutsu-user 33048cb
Fix the tests for Gold Members
dojutsu-user 0a542dd
Reverting back the views and tests.
dojutsu-user f600593
Fix the GoldProjectForm to accept the project's slug
dojutsu-user 662c2ca
Remove the f-string to support python2.7
dojutsu-user 1c31395
Remove extra line at the end of the forms.py
dojutsu-user 0b0e939
Add test for wrong input for the form for gold members to add projects.
dojutsu-user d35cfe0
Fix the indentation problem
dojutsu-user 6653e2e
Remove the 'elif' to correct the linting errors.
dojutsu-user 0294e95
Change double quotes to single quotes
dojutsu-user a0d8816
Separate validation method for 'project' field
dojutsu-user 8a252b7
Fix the test for adding projects for Gold Members
dojutsu-user 567be81
Remove the redundant code.
dojutsu-user fc04ac0
Add support for translation for error message.
dojutsu-user 886a513
Add import for ugettext_lazy
dojutsu-user 728c9d0
Add assert to check the presence of random-incorrect-slug in the data…
dojutsu-user File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to have an assert about that
random-incorrect-slug
doesn't exists on the db