Skip to content

Remove logging verbosity on syncer failure #4717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Remove logging verbosity on syncer failure #4717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions readthedocs/builds/syncers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def copy(cls, path, target, is_file=False, **__):
mkdir_cmd = ("ssh %s@%s mkdir -p %s" % (sync_user, server, target))
ret = os.system(mkdir_cmd)
if ret != 0:
log.error("Copy error to app servers: cmd=%s", mkdir_cmd)
log.debug("Copy error to app servers: cmd=%s", mkdir_cmd)
if is_file:
slash = ""
else:
Expand All @@ -74,7 +74,7 @@ def copy(cls, path, target, is_file=False, **__):
target=target))
ret = os.system(sync_cmd)
if ret != 0:
log.error("Copy error to app servers: cmd=%s", sync_cmd)
log.debug("Copy error to app servers: cmd=%s", sync_cmd)


class DoubleRemotePuller(object):
Expand All @@ -98,7 +98,7 @@ def copy(cls, path, target, host, is_file=False, **__):
)
ret = os.system(mkdir_cmd)
if ret != 0:
log.error("MkDir error to app servers: cmd=%s", mkdir_cmd)
log.debug("MkDir error to app servers: cmd=%s", mkdir_cmd)
# Add a slash when copying directories
sync_cmd = (
"ssh {user}@{server} 'rsync -av "
Expand All @@ -111,7 +111,7 @@ def copy(cls, path, target, host, is_file=False, **__):
target=target))
ret = os.system(sync_cmd)
if ret != 0:
log.error("Copy error to app servers: cmd=%s", sync_cmd)
log.debug("Copy error to app servers: cmd=%s", sync_cmd)


class RemotePuller(object):
Expand All @@ -138,7 +138,7 @@ def copy(cls, path, target, host, is_file=False, **__):
)
ret = os.system(sync_cmd)
if ret != 0:
log.error(
log.debug(
"Copy error to app servers. Command: [%s] Return: [%s]",
sync_cmd,
ret,
Expand Down