Make restapi URL additions conditional #4609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have logic that checks for readthedocsext import availability when adding to INSTALLED_APPS, so checking here for import availability isn't correct. For instance, on the readthedocsinc side, we remove `readthedocsext.donate` from INSTALLED_APPS inherited from settings.base, but urls.py would import the module, add the URLs (for packages that aren't in INSTALLED_APPS anymore), and things broke.
ericholscher
approved these changes
Sep 6, 2018
humitos
approved these changes
Sep 6, 2018
agjohnson
added a commit
that referenced
this pull request
Sep 6, 2018
* Make restapi URL additions conditional We already have logic that checks for readthedocsext import availability when adding to INSTALLED_APPS, so checking here for import availability isn't correct. For instance, on the readthedocsinc side, we remove `readthedocsext.donate` from INSTALLED_APPS inherited from settings.base, but urls.py would import the module, add the URLs (for packages that aren't in INSTALLED_APPS anymore), and things broke. * Fix issues with pylint during strict prospector pass, autolint * Fix issue with py27 and trailing comma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have logic that checks for readthedocsext import availability
when adding to INSTALLED_APPS, so checking here for import availability
isn't correct. For instance, on the readthedocsinc side, we remove
readthedocsext.donatefrom INSTALLED_APPS inherited fromsettings.base, but urls.py would import the module, add the URLs (for
packages that aren't in INSTALLED_APPS anymore), and things broke.