Fixes an issue with duplicate gold subscriptions #4597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfischer
commented
Aug 31, 2018
| subscription = subscriptions.data[0] | ||
| subscription.plan = self.cleaned_data['level'] | ||
| if 'stripe_token' in self.cleaned_data: | ||
| if 'stripe_token' in self.cleaned_data and self.cleaned_data['stripe_token']: |
There was a problem hiding this comment.
The error was on this line specifically. In the case where the user is swapping their credit card, the stripe_token is present and the API call succeeds and everything is good. In the case where the user is just changing plans, stripe_token is None, the API call fails and the except clause is taken which adds a new subscription.
Because of that possibility of just having a failed API call result in more subscriptions, I rewrote that part of this function.
I have cancelled all duplicate subscriptions and refunded Gold Members for the duplicate charges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that could result in a user having multiple gold subscriptions.
I am also going to go back through our gold subscriptions and find any users that have more than 1 subscription as that is likely an error.
Fixes #4595
Fixes #4503